Re: buildpkg - a new way to build packages

fushark · **Joined:** Fri Mar 30, 2007 5:51 am **Posts:** 1677

This idea is a result of my conversation with hennes. It might sound overkill, but since we have zen-pkgcheck.pl, can it be included as a dependency? Then, please add it to the generated buildscript to execute zen-pkgcheck.pl on the package. This is to make sure the packagers complies to most if not all the packaging rules before posting the package to testing.

Sparky · **Posted:** Tue Jan 22, 2008 7:55 pm

That seems like a good idea to me for sure. I always run my packages through zen-pkgcheck.pl, and it would be pretty handy to have it automatically happen during the buildpkg -X process.

hennes · **Posted:** Tue Jan 22, 2008 8:10 pm

Sparky wrote:

...would be pretty handy to have it automatically happen during the buildpkg -X process.

Or maybe as an extra CLI option to buildpkg.

_PN_boy · **Posted:** Tue Jan 22, 2008 8:44 pm

hennes wrote:

Or maybe as an extra CLI option to buildpkg.

I agree[an option is preferable], I'll implement it

_PN_boy · **Posted:** Sat Feb 23, 2008 8:33 pm

Finally...the new version 1.4.3:

CHANGELOG: added -z or --zen-pkgcheck option to use zen-pkgcheck to check for rules complainces (only if run through buildpkg, it is not done in the generated buildscript)

Sparky · **Posted:** Sun Feb 24, 2008 6:27 am

Excellent! I'll compile using -zX from now on, I think.

gapan · **Posted:** Fri Mar 21, 2008 6:02 pm

An idea I just had: what if buildpkg ran

Code:

ls -lR $startdir/pkg

before finishing so that all files permissions and ownerships would be appendend in the log file? That would be an easy way to check those I think.

_PN_boy · **Posted:** Sun Mar 23, 2008 8:23 pm

Hi,

gapan wrote:

An idea I just had: what if buildpkg ran

Code:

ls -lR $startdir/pkg

before finishing so that all files permissions and ownerships would be appendend in the log file? That would be an easy way to check those I think.

That ain't an easy thing to do...
If the script is run with the option to delete the build directories, it would make this option unusable.
After all, the log file is an accommodation in buildpkg.
Here's the problem:
*the created buildscript will delete the build directories, so make it inside the buildscript would the only solution.
*the log file is created by running the build-*.sh generate file (and it's this file that deletes the build directories[if instructed])

The only solution for this would to make the build-*.sh itself generate the buildlog.

Regards,

gapan · **Posted:** Tue Mar 25, 2008 10:48 am

I meant something like making create_package like this:

Code:

create_package() {
   cd $startdir/pkg
   echo -e "\n=== Listing all files in the package (Start) ===\n"
   ls -lR
   echo -e "\n=== Listing all files in the package (End) ===\n"
   /sbin/makepkg -l y -c n $startdir/$package.tgz
   cd $startdir
   md5sum $package.tgz > $startdir/$package.md5
}

Atticus · **Joined:** Mon Mar 03, 2008 7:02 pm **Posts:** 227

I'm not sure if this is a bug or not, but there have been a few times where I'll put something like the following in the source (from a ZENBUILD)

source=(http://example.com/download.php?file=blah-1.2.3.tar.gz)

And when it downloads the file, it names it "download.php...." instead of "blah-1.2.3...." which seems to cause problems with buildpkg and the build script.

One example is libchipcard on the ZUR. The ZENBUILD only works if you download the source tarball first, so I removed the url part and just left the source tarball file name. The actual tarball seems to only be available from a link like this, which is:

http://www.aquamaniac.de/sites/download ... 0.0.tar.gz

gapan · **Posted:** Mon Apr 07, 2008 5:56 pm

No, this is not a bug, you just have to provide a "real" location, not a php redirect to it.

If you remove the url part from the source array, you'll end up with the source tarball under /usr/src, so be careful about that.

In cases like this I guess you could upload the source somewhere like your ftp account where you can get it with wget with no problems.

_PN_boy · **Posted:** Tue Apr 08, 2008 7:03 am

That can be added by doing something like:

Code:

downloadlink="http://www.aquamaniac.de/sites/download/download.php?package=02&release=01&file=01&dummy=libchipcard-4.0.0.tar.gz"
file=$(basename $downloadlink | awk -F= '{print $NF}')
wget $downloadlink -O $file

the thing is...do all those "not so user friendly" links have the name of the file in the last parameter?!?

P.S. this won't interfere with direct links

Atticus · **Joined:** Mon Mar 03, 2008 7:02 pm **Posts:** 227

What if, in this specific instance, you can set an override for the filename? Like filename=blah-1.2.3.tar.gz. It's kind of hacky, but it would make this situation workable.

_PN_boy · **Posted:** Sat Jun 07, 2008 4:47 pm

new version 1.5.0
CHANGELOG: * added creation of package.src file from template from ZENBUILD sourcetemplate variable

gapan · **Posted:** Sat Jun 07, 2008 7:36 pm

That's nice, but there are some problems. With this source array for instance:

Code:

source=("http://www.fzort.org/mpr/projects/vulcan/vulcan-0.92.tar.gz" "vulcan.desktop" "vulcan" "icons.tar.gz" "zen-vulcan-0.92-makefile.patch")

the src file ends up like this

Code:

http://www.fzort.org/mpr/projects/vulcan/vulcan-0.92.tar.gz
vulcan.desktop
vulcan
icons.tar.gz
zen-vulcan-0.92-makefile.patch

which is not much help.

I think we should either require all files to be placed in source with a full web address or probably make yet another variable that will point to a source directory somewhere and prefix that to every file that is present without a full address.

And I think the ZENBUILD itself should be included in the src file. Only way I can think of to do this is with the extra variable I mentioned.

Re: buildpkg - a new way to build packages

Who is online